-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement disable and enable of accent characters #172
Implement disable and enable of accent characters #172
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
a1a2cc0
to
cf85e0e
Compare
There are some additional changes to be made to the PR. |
It is ready for review now. The keyboard used to crash for Swedish and Spanish Keyboard on first use on tap of enter. I have fixed it in the PR. |
Can you do a quick fix of the conflicts and then I'll do a final review for this tonight, @angrezichatterbox? :) Or whenever you have time 😊 |
I will do it by tonight. |
a0976da
to
1e77311
Compare
It is ready for review :) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work as always, @angrezichatterbox 😊 Thanks so much for the implementation here!
What are your thoughts on the toasts? You have one for enabling and disabling these options, which isn't something that's currently in Scribe-iOS. Do you think that having these would be important to include in Scribe-iOS, or would it make sense to remove these in another commit at some point?
I think the Switch Item effectively conveys its purpose on its own. Its visual design, along with the text and description, makes it easily identifiable. It might be worth considering whether the Toast adds any additional value. I’d love to hear your opinion about it. |
Contributor checklist
Description
Related issue