Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disable and enable of accent characters #172

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The pull request allows disabling and enabling accent characters in the German, Swedish, and Spanish keyboards. By default they are enabled.

Related issue

Copy link

github-actions bot commented Oct 6, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox angrezichatterbox force-pushed the feat/Implement-disable-enable-accent-characters branch 2 times, most recently from a1a2cc0 to cf85e0e Compare October 6, 2024 08:21
@angrezichatterbox angrezichatterbox requested review from andrewtavis and removed request for andrewtavis October 6, 2024 08:24
@angrezichatterbox
Copy link
Member Author

There are some additional changes to be made to the PR.

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Oct 6, 2024

It is ready for review now. The keyboard used to crash for Swedish and Spanish Keyboard on first use on tap of enter. I have fixed it in the PR.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 6, 2024
@andrewtavis
Copy link
Member

Can you do a quick fix of the conflicts and then I'll do a final review for this tonight, @angrezichatterbox? :) Or whenever you have time 😊

@angrezichatterbox
Copy link
Member Author

Can you do a quick fix of the conflicts and then I'll do a final review for this tonight, @angrezichatterbox? :) Or whenever you have time 😊

I will do it by tonight.

@angrezichatterbox angrezichatterbox force-pushed the feat/Implement-disable-enable-accent-characters branch from a0976da to 1e77311 Compare October 6, 2024 18:16
@angrezichatterbox
Copy link
Member Author

It is ready for review :) .

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work as always, @angrezichatterbox 😊 Thanks so much for the implementation here!

What are your thoughts on the toasts? You have one for enabling and disabling these options, which isn't something that's currently in Scribe-iOS. Do you think that having these would be important to include in Scribe-iOS, or would it make sense to remove these in another commit at some point?

@andrewtavis andrewtavis merged commit 41315a0 into scribe-org:main Oct 6, 2024
1 check passed
@angrezichatterbox
Copy link
Member Author

Wonderful work as always, @angrezichatterbox 😊 Thanks so much for the implementation here!

What are your thoughts on the toasts? You have one for enabling and disabling these options, which isn't something that's currently in Scribe-iOS. Do you think that having these would be important to include in Scribe-iOS, or would it make sense to remove these in another commit at some point?

I think the Switch Item effectively conveys its purpose on its own. Its visual design, along with the text and description, makes it easily identifiable. It might be worth considering whether the Toast adds any additional value. I’d love to hear your opinion about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants