Update detekt.yml to fix the large class lint issue

[KesharwaniArpita]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

This PR fixes linting issues due to Large Class Block by removing the line of code:

EmptyCatchBlock:
        active: true

Related issue

• Fix linting issues due to Large Classes  #125

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

As with the other one, @KesharwaniArpita, it's not just to remove the line, but also to fix the issues that are being hidden by it. Looks like this one is just one issue, but then splitting MyKeyboardView is likely going to be really difficult 🤔

[KesharwaniArpita]

Surely @andrewtavis , I'll do better

[andrewtavis]

You're doing great, @KesharwaniArpita :)

[angrezichatterbox]

As with the other one, @KesharwaniArpita, it's not just to remove the line, but also to fix the issues that are being hidden by it. Looks like this one is just one issue, but then splitting MyKeyboardView is likely going to be difficult 🤔

Yes, you're right @andrewtavis. It would not be easy to split the class and would require a major refactoring which might include several changes to the overall codebase.

[andrewtavis]

Is there a way for us to put an ignore comment to turn detekt off for this file such that the tests pass, and then from there we'll have this fail if another class gets to be too large? We can then pick this up again at some point for a more full refactor? It looks like this discussion here might have some ways of doing this, i.e. adding something like excludes: ['/Scribe-Android/app/src/main/java/be/scri/views/MyKeyboardView.kt']?

[KesharwaniArpita]

Is there a way for us to put an ignore comment to turn detekt off for this file such that the tests pass, and then from there we'll have this fail if another class gets to be too large? We can then pick this up again at some point for a more full refactor? It looks like this discussion here might have some ways of doing this, i.e. adding something like excludes: ['/Scribe-Android/app/src/main/java/be/scri/views/MyKeyboardView.kt']?

You mean by that instead of going straight to this file, we first focus on refactoring other files first and then move back to it later? Like a bottom to top approach?

[andrewtavis]

This is the only class that has this problem, so if we ignore it or its file and just have that class in the file, then we'll be fine with this for now :)

[angrezichatterbox]

Is there a way for us to put an ignore comment to turn detekt off for this file such that the tests pass, and then from there we'll have this fail if another class gets to be too large? We can then pick this up again at some point for a more full refactor? It looks like this discussion here might have some ways of doing this, i.e. adding something like excludes: ['/Scribe-Android/app/src/main/java/be/scri/views/MyKeyboardView.kt']?

@Suppress("LargeClass")

We can add this to the top of the class.

[andrewtavis]

Do you want to make the change here, @KesharwaniArpita? When the tests pass we can then close this :)

[KesharwaniArpita]

@andrewtavis Can I take it as a to do issue instead a WIP? I want to give it a try.

[andrewtavis]

Feel free to commit the change to this PR, @KesharwaniArpita :) It's basically adding @Suppress("LargeClass") right above this class right here and then we'll be done here 😊

[KesharwaniArpita]

Sure!! Thanks @andrewtavis and @angrezichatterbox

[andrewtavis]

Fantastic, @KesharwaniArpita, and thanks for the great suggestion, @angrezichatterbox! 😊