Add layout margin to improve spacing for best visualizing

[MostafaMohamed2002]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

Related issue

• Increase app UI menu option margins and section padding #118

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[MostafaMohamed2002]

hey @andrewtavis I’d appreciate it if you could review it and provide your feedback.

[andrewtavis]

@angrezichatterbox and @henrikth93: Could you two take a quick look and provide your opinions here :) So far is looking really good to me 😊 Maybe some of the margins could be a bit more, but then everything's already in a card, so we don't want it to be too much.

Thanks for the PR, @MostafaMohamed2002!

[henrikth93]

I think it looks good!

[henrikth93]

Looks good

[angrezichatterbox]

Thanks for the PR @MostafaMohamed2002.

Could the bottom padding be adjusted a bit for the about page, as it is not scrollable for some devices? Could the padding below the app settings recycler view be reduced a bit so that when Install Keyboard button is not moved so far down? After these changes, the PR would be great.

Also, I have noticed a bug I don't know if it's just for me but the recycler view consisting of keyboard language seems to increase its size when moving to the page from other pages. It is present in the current main for me. Is it present for others?

[MostafaMohamed2002]

Could the bottom padding be adjusted a bit for the about page, as it is not scrollable for some devices?

how it's not scrollable for some devices ? could you show me ?

[MostafaMohamed2002]

Could the padding below the app settings recycler view be reduced a bit so that when Install Keyboard button is not moved so far down?

i've fixed this

before	after

[angrezichatterbox]

Could the bottom padding be adjusted a bit for the about page, as it is not scrollable for some devices?

how it's not scrollable for some devices ? could you show me ?

The About page is not scrollable for me in Medium Phone API 35.

Image reference is given below

I am not able to scroll beyond that.

Apologies for the delay in response.

[Linfye]

@angrezichatterbox I tested the code from the main branch on my phone, and the About page still cannot be scrolled, which should not be an bug introduced by this PR.

The screen size of my development environment is larger, and I don't need to scroll on this page, so I haven't noticed this problem before.We can open a new issue to address this bug. :)

cc @andrewtavis

[angrezichatterbox]

@angrezichatterbox I tested the code from the main branch on my phone, and the About page still cannot be scrolled, which should not be an bug introduced by this PR.

The screen size of my development environment is larger, and I don't need to scroll on this page, so I haven't noticed this problem before.We can open a new issue to address this bug. :)

cc @andrewtavis

I thought of fixing it in this PR as there was an easy fix present for this. The layout height of the fragment_about and fragment_settings can be changed to wrap_content and an Empty view of 50dp could be added to the bottom. I think this would make it responsive for all devices.

[angrezichatterbox]

@angrezichatterbox I tested the code from the main branch on my phone, and the About page still cannot be scrolled, which should not be an bug introduced by this PR.
The screen size of my development environment is larger, and I don't need to scroll on this page, so I haven't noticed this problem before.We can open a new issue to address this bug. :)
cc @andrewtavis

I thought of fixing it in this PR as there was an easy fix present for this. The layout height of the fragment_about and fragment_settings can be changed to wrap_content and an Empty view of 50dp could be added to the bottom. I think this would make it responsive for all devices.

Thanks, @Linfye for checking the bug with the main branch as well.

[andrewtavis]

Would you be able to handle the merge conflicts here, @MostafaMohamed2002? Please let us know if you need any support! :)

[MostafaMohamed2002]

Would you be able to handle the merge conflicts here, @MostafaMohamed2002? Please let us know if you need any support! :)

I'll try to do my best cause I'm on the phone , can't use my laptop for a couple of days 🥲

[andrewtavis]

Can also be done in a couple days, @MostafaMohamed2002! No stress :)

[MostafaMohamed2002]

Can also be done in a couple days, @MostafaMohamed2002! No stress :)

That Sounds Great 👍

[MahmoudMabrok]

I think we can proceed with PR, right @andrewtavis @angrezichatterbox .

[andrewtavis]

@angrezichatterbox will get to this per a discussion we had 😊 Thanks for the ping, @MahmoudMabrok!

[angrezichatterbox]

It is ready for a review and then merge :)

[andrewtavis]

Last thing that's needed here post merging in main is to hook back in the third party licenses page as the option to navigate to it on the About page isn't showing up.

[angrezichatterbox]

Is the option for the third-party licenses still not visible?

[andrewtavis]

As of last commit it was, @angrezichatterbox :)

[angrezichatterbox]

As of last commit it was, @angrezichatterbox :)

I will look into it and fix it :)

[angrezichatterbox]

Could I get which device your testing it on ?

[andrewtavis]

Could be, sure 🤔 If you're seeing it, then I'll try another device and we can go from there.

[angrezichatterbox]

Could be, sure 🤔 If you're seeing it, then I'll try another device and we can go from there.

Could I get which device the thing was not visible to you? I want it to be responsive for all devices.

[andrewtavis]

Was at work and an event for work all day. Is a Pixel 8 Pro API 35 emulator :) Screenshot of what I'm seeing is:

[angrezichatterbox]

For some reason, it is visible for me in Pixel 8 Pro API 35.

[MahmoudMabrok]

For some reason, it is visible for me in Pixel 8 Pro API 35.

We need to make sure it is scrolling.

We can add extra items manually and check.

[angrezichatterbox]

We need to make sure it is scrolling.

We can add extra items manually and check.

I have added padding to both the recycler view and linear layout which contains the scroll view. This would be fine for the scrolling right.

[angrezichatterbox]

Now the page must be responsive for all devices.

[andrewtavis]

Will check when I get home. Thanks, @angrezichatterbox!

[MahmoudMabrok]

Will check when I get home. Thanks, @angrezichatterbox!

Just a joke, if PR of enhance pipeline was merged, so you will not need to checkout and build app, as apk was already generated in PR , all we need is to download apk and put on device (simulator or real)

so this might allow us to test PRs that is UI without need to build locally (we can by phone download apk and try it).

[andrewtavis]

I do most of my reviews at home so I can have time to relax on commutes 😊 Also beyond that, that in particular won't work for me as I'm on iOS :)

[andrewtavis]

Is working great now 😊 Thanks so much @MostafaMohamed2002 for the great work, @MahmoudMabrok for the review, and @angrezichatterbox for reviewing and bringing us all home 🚀 Wonderful collaboration all :)