107 fix detekt too many functions #203
Conversation
…nctions between all the languages.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
|
CC @angrezichatterbox for #200 that came out of our discussions :) |
|
Let us know when this is ready, @growabeard, and really thanks so much 😊 |
|
I guess this PR would fix most of #200 along with my PR :) |
…move-unused-functions Remove Unused Functions and Classes
…nctions between all the languages.
…s' into 107-fix-detekt-too-many-functions # Conflicts: # app/src/main/java/be/scri/activities/BaseSimpleActivity.kt # app/src/main/java/be/scri/activities/BaseSplashActivity.kt # app/src/main/java/be/scri/extensions/Activity.kt # app/src/main/java/be/scri/extensions/CommonsContext.kt # app/src/main/java/be/scri/extensions/ContextStorage.kt # app/src/main/java/be/scri/extensions/ContextStorageSdk30.kt # app/src/main/java/be/scri/extensions/ContextStyling.kt # app/src/main/java/be/scri/extensions/Cursor.kt # app/src/main/java/be/scri/extensions/Drawable.kt # app/src/main/java/be/scri/extensions/EditText.kt # app/src/main/java/be/scri/extensions/Int.kt # app/src/main/java/be/scri/extensions/Resources.kt # app/src/main/java/be/scri/extensions/String.kt # app/src/main/java/be/scri/fragments/AboutFragment.kt # app/src/main/java/be/scri/fragments/LanguageSettingsFragment.kt # app/src/main/java/be/scri/fragments/SettingsFragment.kt # app/src/main/java/be/scri/helpers/BaseConfig.kt # app/src/main/java/be/scri/helpers/CommonsConstants.kt # app/src/main/java/be/scri/helpers/Constants.kt # app/src/main/java/be/scri/helpers/MyContentProvider.kt # app/src/main/java/be/scri/services/EnglishKeyboardIME.kt # app/src/main/java/be/scri/services/FrenchKeyboardIME.kt # app/src/main/java/be/scri/services/GermanKeyboardIME.kt # app/src/main/java/be/scri/services/ItalianKeyboardIME.kt # app/src/main/java/be/scri/services/PortugueseKeyboardIME.kt # app/src/main/java/be/scri/services/RussianKeyboardIME.kt # app/src/main/java/be/scri/services/ScribeKeyboardIME.kt # app/src/main/java/be/scri/services/SpanishKeyboardIME.kt # app/src/main/java/be/scri/services/SwedishKeyboardIME.kt # app/src/main/java/be/scri/views/MyKeyboardView.kt
|
Closing this PR and I will split into multiple more manageable PRs. |
Contributor checklist
Description
This PR is a WIP attempt to fix the TooManyFunctions detekt metric.
To test, I ran the application locally and attempted to use the app and the keyboard.
Previously it was at 27 issues, and I have reduced that down to 5.
This is a large PR, I understand. Most of the code was unused. Some of it was restructured to add layers of inheritance.
The remaining offenders are
-MyKeyboardView: 30 functions
-BaseSimpleActivity: 27 functions
-SimpleKeyboardIME: 21 functions
-ContextStorage: 15 functions
-SettingsFragment: 13 functions
I'm not sure if we should add suppression annotations to these classes or if I should proceed and try to whittle this down further.
Related issue