-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emoji autocompletions #220
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
22a9246
to
7e48e2e
Compare
@andrewtavis I have completed this work, could you review the code? Thanks. 😊 There is still an small problem. After outputting an emoji using this feature, you need to press the backspace twice to delete the outputted emoji. This seems to be related to the encoding method of the emoji, and it should be possible to resolve this issue by modifying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Linfye for this. Everything looks and functions great.
And yes, I do think modifying the delete key function would be the right choice. We could add a condition where if the previous character is an emoji, it would delete the surrounding twice and the other cases as usual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you keeping at this for as long as you have, @Linfye 😊 So great to have you on the project, and looking forward to seeing this feature develop even more!
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This is a draft PR, and the functionality is not yet complete. I will improve it following the steps below.Related issue