Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Added formating fixes in pre-commit #221

Merged

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

The PR adds auto-formatting during the pre-commit. Also, for some reason, the pre-commit was not working on my device and some of the other devices on which I tested it. I have added an sh to run the script. Currently, the thing fails if it has to auto format, as there must be changes to the codebase. I am happy to have suggestions so that it does not fail whether it makes changes and also on the changes on adding sh to run the command.

Related issue

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 24, 2024
@andrewtavis
Copy link
Member

Can you let me know what further changes need to happen here, @angrezichatterbox? I think you mentioned that there are some issues with pre-commit, and the whitespace at the end of the file not being removed points to this definitely being a problem.

@angrezichatterbox
Copy link
Member Author

For now, I have made the changes so that it will work fine. I have made the trailing-whitespace and end-of-file-fixer only for Kotlin files as it was changing the contents of the i18n and other files that I'm not sure are required.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing up the confusion, @angrezichatterbox 😊

@andrewtavis andrewtavis merged commit f2286b6 into scribe-org:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants