Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TooManyFunctions in Fragments and MainActivity. #222

Merged
merged 20 commits into from
Oct 25, 2024

Conversation

growabeard
Copy link
Collaborator

Contributor checklist


Description

I have gone through the fragments package and the MainActivity to fix the TooManyFunctions detekt issue by refactoring common code and moving out code that was doing work outside the responsibility of the class it was previously in (example: MainActivity getting the preferences for dark mode, when that should be owned by the PreferencesHelper.)

I have added an annotation to the remaining classes (SimpleKeyboardIME and MyKeyboardView) because they are very large and I'm not sure if they can be split up.

Related issue

Copy link

github-actions bot commented Oct 24, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 24, 2024
@angrezichatterbox
Copy link
Member

Screenshot 2024-10-24 at 8 55 16 PM Screenshot 2024-10-24 at 8 55 22 PM

Could you look into why the action bar title is not aligned?

@growabeard
Copy link
Collaborator Author

growabeard commented Oct 25, 2024

Screenshot 2024-10-24 at 8 55 16 PM Screenshot 2024-10-24 at 8 55 22 PM
Could you look into why the action bar title is not aligned?

Nice find @angrezichatterbox, I flipped the margin settings when I combined them. It should be fixed now.

@angrezichatterbox
Copy link
Member

Could you look into why the action bar title is not aligned?

Nice find @angrezichatterbox, I flipped the margin settings when I combined them. It should be fixed now.

Everything else looks good to me @growabeard. It is good for merge. Thanks :)

@andrewtavis
Copy link
Member

Thanks for the work here @growabeard, and also for the thorough review, @angrezichatterbox! :)

@andrewtavis andrewtavis merged commit 04bfee0 into scribe-org:main Oct 25, 2024
2 checks passed
@growabeard growabeard deleted the fix-toomanyfunctions-fragments branch October 28, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants