-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TooManyFunctions in Fragments and MainActivity. #222
Fix TooManyFunctions in Fragments and MainActivity. #222
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Nice find @angrezichatterbox, I flipped the margin settings when I combined them. It should be fixed now. |
Everything else looks good to me @growabeard. It is good for merge. Thanks :) |
Thanks for the work here @growabeard, and also for the thorough review, @angrezichatterbox! :) |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
I have gone through the fragments package and the MainActivity to fix the TooManyFunctions detekt issue by refactoring common code and moving out code that was doing work outside the responsibility of the class it was previously in (example: MainActivity getting the preferences for dark mode, when that should be owned by the PreferencesHelper.)
I have added an annotation to the remaining classes (
SimpleKeyboardIME
andMyKeyboardView
) because they are very large and I'm not sure if they can be split up.Related issue