Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the settings page to Jetpack Compose #252

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

The pull request moves the settings page to Jetpack Compose. A separate issue would be created to migrate the Language settings page to Jetpack Compose since it’s too large to fit within the same PR.

Related issue

#247

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox angrezichatterbox force-pushed the feature/Migrate-SettingsPage-To-Compose branch from d9314cb to c9ba366 Compare November 27, 2024 15:24
@angrezichatterbox
Copy link
Member Author

Happy to make changes to any visual detail that I might have missed while migrating to Jetpack Compose.

@andrewtavis
Copy link
Member

Generally all's looking really good, @angrezichatterbox :) One thing I'm seeing is that the divider line for language sub menus isn't quite right? Should be more in the middle? See below:

Screenshot 2024-11-27 at 19 56 56

Aside from that, would you suggest that the toggles change style as they have? The new versions have a cta orange outline if they're not active rather than just a grey background, and there's also padding around the circular interactive element of the toggle, where before it there was no padding. Happy to hear your feedback on this and we can go from there! Would just be good to make sure that iOS and Android are the same, but we can work on it :)

@angrezichatterbox
Copy link
Member Author

Generally all's looking really good, @angrezichatterbox :) One thing I'm seeing is that the divider line for language sub menus isn't quite right? Should be more in the middle? See below:

Screenshot 2024-11-27 at 19 56 56

Aside from that, would you suggest that the toggles change style as they have? The new versions have a cta orange outline if they're not active rather than just a grey background, and there's also padding around the circular interactive element of the toggle, where before it there was no padding. Happy to hear your feedback on this and we can go from there! Would just be good to make sure that iOS and Android are the same, but we can work on it :)

So currently I am directly using Material Switches I would make it to use the earlier switch. I missed it during the migration. I would also make the divider towards the centre. Thanks :)

@angrezichatterbox
Copy link
Member Author

I have tried to make it as similar as possible to the earlier switches. If at all it feels not so similar Happy to make custom switches to make it even more similar.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the word here, @angrezichatterbox! In looking at the toggle designs I made the new versions are much better than the old ones 😊 Thanks for the attention to detail here and continuing the migration!

@andrewtavis andrewtavis merged commit 666bc92 into scribe-org:main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants