-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated language settings screen from XML to Jetpack compose #254
Migrated language settings screen from XML to Jetpack compose #254
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.email
in their local Scribe-Android repo
@andrewtavis @angrezichatterbox Ready for review |
Thanks for the quick work here, @Saifuddin53! I'll get to my review this weekend 😊 Great to have you on the project :) |
Had a moment to check the UI and it's all looking great 😊 Thanks @Saifuddin53 and @angrezichatterbox for working towards such a professional and technologically sound application :) @angrezichatterbox, do you want to do a quick check of the code and then we can bring this in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saifuddin53, your work on refactoring the compose codebase into reusable and maintainable components is truly impressive. The page you’ve created is also amazing. I hope we’ll see you around solving more issues in the future.
There are a few linting issues that could be resolved by running ./gradlew formatKotlin
.
} | ||
|
||
|
||
enum class ItemType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently not being used right and could be removed or the codebase could be modified to use them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enum class is no more of use and the other two data classes can be used in the future when we migrate the About page to compose
Thank you so much, @andrewtavis and @angrezichatterbox, for your encouraging words and support! 😊. Looking forward to collaborating on more exciting issues in the future. @angrezichatterbox, I’ve resolved the linting issues as you suggested and have removed the unused code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks Great now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for the amazing collaboration here for a great result! 😊 Looking forward to the next issue, @Saifuddin53 🚀
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
The pull request moves the language settings page to Jetpack Compose and has refactored the settings composable to use the reusable components that were created in this PR
Screenshots
Settings:
Language Settings:
Migrate the Language settings page to Jetpack Compose #253