-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added interface variables strings constant to be used in the keyboard #255
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
@andrewtavis @angrezichatterbox I've implemented all the interface variables for Spanish (for now). Could you please review this and let me know if this is the implementation you had in mind? Please let me know if any modifications are needed or if you have any suggestions 🙂 |
Looks good to me. The organization is perfect for constants. |
@angrezichatterbox @andrewtavis ready for review |
Could we discuss really quick the linting errors that are suggesting that we do screaming snake case for variables that won't change? That makes sense to me :) I guess that Swift doesn't have that convention, but if that's what ktlint suggests then I'd say we'd be good to follow it 😊 |
@andrewtavis I’ve updated the variable names to follow the screaming snake case convention. Thank you for your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here, @Saifuddin53! I switched over these files to have succinct marks as sections that will show up in some code editors :) That's a more clean way of doing sections, as comments that are their own lines would ideally be fully punctuated sentences.
Looking forward to the next time we work with you!
What I get for using VS Code to do something quick 😅 I'll fix the linting errors and then bring this in :) |
Thanks for the review and help @andrewtavis 🫡🫡 |
If we are migrating the keyboard to compose we would have to rework the entire MyKeyboardView.kt and The IME. I am not sure if it is something necessary to be done as most keyboards are still using XML layouts as it wouldn't be easy to work with the IME using Compose. |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
In this PR, I’ve added all required interface variable strings to the keyboard constants for each language. Based on the new approach, these strings are now hard-coded into each keyboard file rather than being localized via Weblate.
Related issue