Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interface variables strings constant to be used in the keyboard #255

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

Saifuddin53
Copy link
Contributor

@Saifuddin53 Saifuddin53 commented Dec 1, 2024

Contributor checklist


Description

In this PR, I’ve added all required interface variable strings to the keyboard constants for each language. Based on the new approach, these strings are now hard-coded into each keyboard file rather than being localized via Weblate.

Related issue

Copy link

github-actions bot commented Dec 1, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Saifuddin53 Saifuddin53 marked this pull request as draft December 1, 2024 07:32
@Saifuddin53
Copy link
Contributor Author

@andrewtavis @angrezichatterbox I've implemented all the interface variables for Spanish (for now). Could you please review this and let me know if this is the implementation you had in mind? Please let me know if any modifications are needed or if you have any suggestions 🙂

@angrezichatterbox
Copy link
Member

Looks good to me. The organization is perfect for constants.

@Saifuddin53 Saifuddin53 marked this pull request as ready for review December 1, 2024 16:04
@Saifuddin53
Copy link
Contributor Author

@angrezichatterbox @andrewtavis ready for review

@andrewtavis
Copy link
Member

Could we discuss really quick the linting errors that are suggesting that we do screaming snake case for variables that won't change? That makes sense to me :) I guess that Swift doesn't have that convention, but if that's what ktlint suggests then I'd say we'd be good to follow it 😊

@andrewtavis andrewtavis self-requested a review December 1, 2024 18:09
@Saifuddin53
Copy link
Contributor Author

@andrewtavis I’ve updated the variable names to follow the screaming snake case convention. Thank you for your feedback ☺️

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here, @Saifuddin53! I switched over these files to have succinct marks as sections that will show up in some code editors :) That's a more clean way of doing sections, as comments that are their own lines would ideally be fully punctuated sentences.

Looking forward to the next time we work with you!

@andrewtavis
Copy link
Member

What I get for using VS Code to do something quick 😅 I'll fix the linting errors and then bring this in :)

@andrewtavis andrewtavis merged commit 44d87ed into scribe-org:main Dec 2, 2024
4 checks passed
@Saifuddin53
Copy link
Contributor Author

Thanks for the review and help @andrewtavis 🫡🫡
Can I work on the migration of the About page to compose if the assignee is not currently working on it
Also are we going to migrate the keyboard layout to compose as well?

@angrezichatterbox
Copy link
Member

If we are migrating the keyboard to compose we would have to rework the entire MyKeyboardView.kt and The IME. I am not sure if it is something necessary to be done as most keyboards are still using XML layouts as it wouldn't be easy to work with the IME using Compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants