-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated about page from XML to Jetpack Compose #260
Migrated about page from XML to Jetpack Compose #260
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Saifuddin53. All the changes look good to me :)
Thanks for the review @angrezichatterbox |
@angrezichatterbox, do you want to bring this one in? 😊 |
Changes look good to me as well and all's functions wonderfully :) |
I can also merge later this evening after work, but if you do want to merge, @angrezichatterbox, then also remember to close this issue as well 🚀 |
I’ll bring this one in and close the issue as well :) |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
The pull request moves the about page to Jetpack Compose
Screenshots
Related issue