Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated about page from XML to Jetpack Compose #260

Merged

Conversation

Saifuddin53
Copy link
Contributor

@Saifuddin53 Saifuddin53 commented Dec 6, 2024

Contributor checklist


Description

The pull request moves the about page to Jetpack Compose

Screenshots

Before After
Before WhatsApp Image 2024-12-06 at 10 55 20_ea973503

Related issue

Copy link

github-actions bot commented Dec 6, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Saifuddin53. All the changes look good to me :)

@Saifuddin53
Copy link
Contributor Author

Thanks for the review @angrezichatterbox ☺️

@andrewtavis
Copy link
Member

@angrezichatterbox, do you want to bring this one in? 😊

@andrewtavis
Copy link
Member

Changes look good to me as well and all's functions wonderfully :)

@andrewtavis
Copy link
Member

I can also merge later this evening after work, but if you do want to merge, @angrezichatterbox, then also remember to close this issue as well 🚀

@angrezichatterbox
Copy link
Member

I can also merge later this evening after work, but if you do want to merge, @angrezichatterbox, then also remember to close this issue as well 🚀

I’ll bring this one in and close the issue as well :)

@angrezichatterbox angrezichatterbox merged commit 0c601aa into scribe-org:main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants