Enable and disable comma and period on ABC

[henrikth93]

This commit will implement the functionality for the toggle"disable/enable comma and period on ABC"-option

Contributor checklist

• [] This pull request is on a separate branch and not the main branch
• [] I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

---

Description

Related issue

• Disable Period and comma on ABC keyboard  #148

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

@angrezichatterbox, one thing to note here is that a lot of XML layouts are being added here. Not sure if this is something that could be improved by a switch to Compose, but this would maybe be an argument for making the switch if so. Other suggestions would be welcome!

[angrezichatterbox]

@angrezichatterbox, one thing to note here is that a lot of XML layouts are being added here. Not sure if this is something that could be improved by a switch to Compose, but this would maybe be an argument for making the switch if so. Other suggestions would be welcome!

I think it is always a better decision to switch to compose. I just had the query of whether there would be any issues handling compose views with the Keyboard IME and its ease and most of the keyboard are in XML. However we could try it out for sure Migrating it to compose.

[andrewtavis]

In your opinion though we're good to merge this in and then we can include it in the migration later, @angrezichatterbox? :)

[angrezichatterbox]

In your opinion though we're good to merge this in and then we can include it in the migration later, @angrezichatterbox? :)

Yes, I think it is good to merge.

Just a small change I would like The Toast is currently misplaced for on and off. And I think it would be better to keep period and comma on by default for the keyboard since it is an android standard.

[andrewtavis]

@henrikth93, do you want to address the change to the Toast as @angrezichatterbox indicated and then we'll bring this in? :)

[henrikth93]

Sure, gonna try and do this this evening. Den mån 9 dec. 2024 kl 19:06 skrev Andrew Tavis McAllister < ***@***.***>:

…

@henrikth93 <https://github.com/henrikth93>, do you want to address the change to the Toast as @angrezichatterbox <https://github.com/angrezichatterbox> indicated and then we'll bring this in? :) — Reply to this email directly, view it on GitHub <#263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZN5AUQFQ3FJ7D4A4OIXMBD2EXLYTAVCNFSM6AAAAABTHPRMRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRYHE2TINZZGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[andrewtavis]

@henrikth93 and @angrezichatterbox: Can we take a look at why the tests are failing here now? :)

[angrezichatterbox]

@henrikth93 and @angrezichatterbox: Can we take a look at why the tests are failing here now? :)

The errors displayed were network-related issues. The workflow successfully executes when it’s rerun.

[andrewtavis]

Nice, I assumed that but then they failed on me a second time :) Thanks, @angrezichatterbox!

[andrewtavis]

All's working well here now 😊 Thanks much for the great work here, @henrikth93, as well as the quick reaction to @angrezichatterbox's review :) Amazing to have this functionality in both apps now so the keyboards are more accessible to those switching devices!