-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Language-Specific Placeholders and Prompts for Scribe Keyboard #285
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.email
in their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL"
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All's working really well here, @akshayw1, and this is a great first step to getting the command functionality up and running! I'll be making a few issues based on the current state of the application right now. Maybe these include the work that needs to be done you were referring to, but of course let me know if there are other issues you think we need to make! Also feel free to pick up another issue 😊
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the [testing section of the contributing guide](https://github.com/scribe-org/Scribe-Android/blob/main/CONTRIBUTING.md#testing)Description
This PR addresses a major issue for adding functionality to the Scribe keyboard. It ensures that all labels and placeholder texts are added for the command buttons in the Scribe-Android keyboard, while also considering language-specific prompts from the helper files. Here's what was implemented:
Modular Code and Language Support:
ENInterfaceVariables
,FRInterfaceVariables
, etc.) are used to handle prompts and labels in the corresponding language.Screenshots of Changes
Testing
./gradlew lintKotlin
and resolved any lint issues.Related issue