Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app label name - debug mode #291

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

mnzoidi
Copy link
Contributor

@mnzoidi mnzoidi commented Jan 2, 2025

Contributor checklist


Description

The app - when you run it with debug mode on a phone - didn't have a label. The issue was that the label in the strings.xml under the debug folder had an empty label. I removed it and now the name is shown propperly.

2025-01-03_00-06-33-441

Related issue

mnzoidi and others added 2 commits January 2, 2025 23:48
Copy link

github-actions bot commented Jan 2, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis andrewtavis self-requested a review January 2, 2025 22:17
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the issue and a first great contribution, @mnzoidi! Great to have attention being put into phone based testing! Looking forward to working with you again 😊

@andrewtavis andrewtavis merged commit 6014f75 into scribe-org:main Jan 2, 2025
5 checks passed
@andrewtavis andrewtavis mentioned this pull request Jan 2, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants