Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Scribe Key Icon and Cancel Key Icon Colors to White in Dark Mode & Make Emoji Key Background Transparent #292

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

akshayw1
Copy link
Contributor

@akshayw1 akshayw1 commented Jan 4, 2025

Contributor Checklist


Description

This pull request addresses two issues:

  1. Dark Mode Enhancements (Change Scribe key icon and cancel key icon colors to white in dark mode #289)

    • Changed the Scribe key icon and Cancel key icon colors to white for better visibility in dark mode.
  2. Emoji Key Background Update (Make emoji key background transparent #288)

    • Made the emoji key background transparent to align with UI design standards.

Changes Made:

  • Updated the dark mode color theme to apply white to the specified key icons.
  • Adjusted the emoji key background property to make it transparent.
  • Verified changes across various modes and themes.
  • Added Seperator to emoji key

Related Issues


Screenshots

image image

Testing

  • Verified functionality by enabling dark mode and testing the key icons.
  • Confirmed transparency for the emoji key background by checking across light and dark modes.

Thank you for reviewing this PR! 🚀

Copy link

github-actions bot commented Jan 4, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's looking great here, @akshayw1! Really appreciate the quick work on both of these issues 😊 The keyboard UI's really coming along!

@andrewtavis andrewtavis merged commit 8f4f229 into scribe-org:main Jan 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants