-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Added Shadow to the keys and reduced border radius #37
feat:Added Shadow to the keys and reduced border radius #37
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
I'm getting some errors in trying to build this, @angrezichatterbox :)
Do you want to take a look at them? I'll get the PR template up now :) |
PR template is here, and you'll see the raw text in your next PR, @angrezichatterbox. Let me know if you have any suggestions for the template! |
I have fixed the error . I forgot to implement the functions after creating a branch from the new main. |
Thanks , It is very helpful |
I'll get to the review later this evening, @angrezichatterbox :) |
What would be an issue you'd think to look into next? Maybe #27 so we can finish that functionality up? There was a PR, but it only works for some devices. |
I will check it out and start working on that issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All's looking great, @angrezichatterbox! Thanks so much for the communication on this issue that got us to such a nice result 😊
1e07813 Merge pull request scribe-org#42 from angrezichatterbox/XML-TO-JSON-FIX 2a8fe2a fix:Added escape characters for \n 924f00c scribe-org#37 minor edits to conversion scripts and try new command path aafa0f6 scribe-org#37 update Scribe-i18n structure and fix conversion workflow 6a8faaa Merge pull request scribe-org#39 from Jag-Marcel/i18n-refactor 2b9caff Added newline at end of all JSON files e775e46 Updated jsons and xcstrings file using new iOS scripts dd018c1 Refactored iOS conversion scripts to use python json package 7f8c273 Updated conversion workflow to use paths filter instead of conditional check ff21cdb Refactored scripts into new iOS and Android folders git-subtree-dir: app/src/main/assets/i18n git-subtree-split: 1e07813b694edc57934b46ec76943cc1e974d4fb
The pull request is to make the keyboard similar to the iOS Scribe-App by adding white key and a small shadow below the keys