Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference strings from i18n folder #57

Merged

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

The strings will now be referenced from the i18n folder, which is a subtree of Scribe-i18n. The About page is fully localized, as it was recently created and all the strings were available. The bottom navigation bar is also localized. However, the other pages could not be localized because the strings were not present. As a result, the old strings.xml is still present. I will create a document for the strings currently referenced in the various files from strings.xml.

Related issue

Copy link

github-actions bot commented Aug 14, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks for this, @angrezichatterbox! I'll try to get the review done this evening :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing to see Scribe-Android adopt things that are so new to Scribe-iOS so early in its life, @angrezichatterbox 😊 Thanks so much for this! So great that Scribe-i18n can already fulfill it's purpose :) :)

@andrewtavis andrewtavis merged commit 6c750f8 into scribe-org:main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants