-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate from Groovy to Kotlin Build configuration #82
feat: Migrate from Groovy to Kotlin Build configuration #82
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
It seems detekt did not have a source earlier. Now detekt seems to work properly. Should I disable those rules as well for now? |
Yes, @angrezichatterbox, sounds good. Would be great if you disable the rules and make good first issues for enabling them and fixing all of their errors 😊 |
Yes I will disable the rules and make all the issues together :). |
Let me know when this is ready for a final review, @angrezichatterbox :) |
2354dec
to
5a95976
Compare
There seem to be a lot that detekt seems to find. I will add them all and then comment in here. |
9abbfd3
to
15a148b
Compare
15a148b
to
9c43352
Compare
It is now ready for review. There are around 26 that I have disabled. |
@@ -0,0 +1,65 @@ | |||
style: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, @angrezichatterbox :) Feel free to make good first issues for each of these that we want to be enabled!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make issues for those :).
@angrezichatterbox, I'm getting the following error when trying to build:
Are you able to build the project on this branch? |
Note that you'll need to bring my changes down 😊 |
I have fixed this error. I had made some changes to try to get detekt running on my system. Sorry. |
No stress whatsoever, @angrezichatterbox! Will review it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App's running great and as noted before the build files are now much more straightforward :) Thanks for this, @angrezichatterbox! Really great that this is being handled pre Hacktoberfest 🎃
Contributor checklist
Description
Related issue