Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate from Groovy to Kotlin Build configuration #82

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The pull request migrates the Build configuration files from Groovy to Kotlin.
  • Kapt has been changed to ksp as it was showing up as warnings to Migrate from kapt to ksp.

Related issue

Copy link

github-actions bot commented Sep 6, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Sep 6, 2024

It seems detekt did not have a source earlier. Now detekt seems to work properly. Should I disable those rules as well for now?

@andrewtavis
Copy link
Member

Yes, @angrezichatterbox, sounds good. Would be great if you disable the rules and make good first issues for enabling them and fixing all of their errors 😊

@angrezichatterbox
Copy link
Member Author

Yes, @angrezichatterbox, sounds good. Would be great if you disable the rules and make good first issues for enabling them and fixing all of their errors 😊

Yes I will disable the rules and make all the issues together :).

@andrewtavis
Copy link
Member

Let me know when this is ready for a final review, @angrezichatterbox :)

@angrezichatterbox angrezichatterbox force-pushed the Migrate-From-Groovy-To-Kotlin-Build-Config branch from 2354dec to 5a95976 Compare September 6, 2024 16:32
@angrezichatterbox
Copy link
Member Author

Let me know when this is ready for a final review, @angrezichatterbox :)

There seem to be a lot that detekt seems to find. I will add them all and then comment in here.

@angrezichatterbox angrezichatterbox force-pushed the Migrate-From-Groovy-To-Kotlin-Build-Config branch from 9abbfd3 to 15a148b Compare September 6, 2024 17:21
@angrezichatterbox angrezichatterbox force-pushed the Migrate-From-Groovy-To-Kotlin-Build-Config branch from 15a148b to 9c43352 Compare September 6, 2024 17:24
@angrezichatterbox
Copy link
Member Author

It is now ready for review. There are around 26 that I have disabled.

@@ -0,0 +1,65 @@
style:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @angrezichatterbox :) Feel free to make good first issues for each of these that we want to be enabled!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make issues for those :).

@andrewtavis
Copy link
Member

@angrezichatterbox, I'm getting the following error when trying to build:

Execution failed for task ':app:kspCoreDebugKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileCoreDebugJavaWithJavac' (1.8) and 'kspCoreDebugKotlin' (17).

Are you able to build the project on this branch?

@andrewtavis
Copy link
Member

Note that you'll need to bring my changes down 😊

@angrezichatterbox
Copy link
Member Author

@angrezichatterbox, I'm getting the following error when trying to build:

Execution failed for task ':app:kspCoreDebugKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileCoreDebugJavaWithJavac' (1.8) and 'kspCoreDebugKotlin' (17).

Are you able to build the project on this branch?

I have fixed this error. I had made some changes to try to get detekt running on my system. Sorry.

@andrewtavis
Copy link
Member

No stress whatsoever, @angrezichatterbox! Will review it now :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App's running great and as noted before the build files are now much more straightforward :) Thanks for this, @angrezichatterbox! Really great that this is being handled pre Hacktoberfest 🎃

@andrewtavis andrewtavis merged commit a9279ad into scribe-org:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants