-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/sphinx docs build issue #418
Fix/sphinx docs build issue #418
Conversation
- Removed the import and usage of get_language_words_to_ignore from process_wiki.py. - Updated the gen_autosuggestions function to use an empty list for ignore words.
- Eliminated the import statement for get_language_words_to_remove. - Updated process_wiki.py to remove the dependency on this function.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to build the doc successfully now. Great work @OmarAI2003! ✨
This is a great thing to hear. You're welcome. |
…phinx-autobuild and sphinx-build
With this last commit, the docs now build for |
Let's see if the current one deploys to Read the Docs. If yes, then no stress 😊 If no, then we can revisit it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @OmarAI2003! Let's see how this works :)
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
get_html_theme_path()
in theconf.py
file to resolve Sphinx build issues.process_wiki.py
by removing the outdated reference toget_language_words_to_remove
andget_language_words_to_ignore
.Details:
Testing:
sphinx-build -b html docs/source/ build/
, resulting in a successful build with no warnings.Let me Know your thoughts
@Khushalsarode, @AnishereMariam
Related issue