Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nouns query for latvian language #425

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

Khushalsarode
Copy link
Contributor

@Khushalsarode Khushalsarode commented Oct 18, 2024

Contributor checklist


Description

@andrewtavis

Copy link

github-actions bot commented Oct 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
@andrewtavis andrewtavis self-requested a review October 18, 2024 17:13
@Khushalsarode
Copy link
Contributor Author

@andrewtavis structure check workflow: created new dir named latvian into language_data_extraction as there was no dir.

@andrewtavis
Copy link
Member

We can figure out the structure check workflow later, @Khushalsarode. This query currently returns no forms even though there are forms on Latvian nouns available. Can you please reference the new SPARQL query writing docs and make the needed changes to get all the forms? Thank you :)

@Khushalsarode
Copy link
Contributor Author

We can figure out the structure check workflow later, @Khushalsarode. This query currently returns no forms even though there are forms on Latvian nouns available. Can you please reference the new SPARQL query writing docs and make the needed changes to get all the forms? Thank you :)

Sure!

@andrewtavis
Copy link
Member

Thank you :)

@Khushalsarode
Copy link
Contributor Author

We can figure out the structure check workflow later, @Khushalsarode. This query currently returns no forms even though there are forms on Latvian nouns available. Can you please reference the new SPARQL query writing docs and make the needed changes to get all the forms? Thank you :)

updated the query as you asked! please do check, let me know.
@andrewtavis

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still many forms missing, @Khushalsarode, but it was easy enough for me to expand. Please check the final version of the query and use that as a reference for future ones as this is a relatively expansive one for nouns 😊

@andrewtavis andrewtavis merged commit 0270dbb into scribe-org:main Oct 19, 2024
5 checks passed
@Khushalsarode
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants