-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Igbo data queries #434
Igbo data queries #434
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Hi @andrewtavis I done with all the Igbo data queries except for the verb. Please do review to let me know if I'm on track. Also I will finish up with the Estonian verb and Polish data queries. Thank you |
Hi @KesharwaniArpita Please can you guide me on how to troubleshoot this fail check |
Hi @Ekikereabasi-Nk Can you show me the error you are getting? I am also having little issues with the |
@KesharwaniArpita These are the error Run python check_project_structure.py
|
@KesharwaniArpita Thanks a lot I will try it out |
Checking in here, are we ready for a review, or is there still some work to be done? Thanks for the collaboration, you two! |
d69ba6b
to
99fe85c
Compare
99fe85c
to
9adc051
Compare
Hi @andrewtavis I have done some minor update on the query, please take a look. Thank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates here, @Ekikereabasi-Nk! I think that the amount of data isn't quite enough for us to have a good understanding of how the data will eventually be modeled, so let's keep the queries simple for now and expand them when more forms are available 😊
Alright @andrewtavis, thank you. |
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR expand the Igbo language data extraction capabilities in
src/scribe_data/language_data_extraction/Igbo
by implementing comprehensive SPARQL queries to fetch grammatical features and form from Wikidata.All SPARQL queries were test and validate on wikidata query service