Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igbo data queries #434

Merged
merged 4 commits into from
Oct 20, 2024
Merged

Conversation

Ekikereabasi-Nk
Copy link
Contributor

@Ekikereabasi-Nk Ekikereabasi-Nk commented Oct 19, 2024

Contributor checklist


Description

This PR expand the Igbo language data extraction capabilities in src/scribe_data/language_data_extraction/Igbo by implementing comprehensive SPARQL queries to fetch grammatical features and form from Wikidata.

All SPARQL queries were test and validate on wikidata query service

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Ekikereabasi-Nk
Copy link
Contributor Author

Ekikereabasi-Nk commented Oct 19, 2024

Hi @andrewtavis I done with all the Igbo data queries except for the verb. Please do review to let me know if I'm on track. Also I will finish up with the Estonian verb and Polish data queries. Thank you

@Ekikereabasi-Nk
Copy link
Contributor Author

Hi @KesharwaniArpita Please can you guide me on how to troubleshoot this fail check Check Project Structure / structure-check (pull_request) . I have tried to troubleshoot it, but its not working. Thank you

@KesharwaniArpita
Copy link
Contributor

Hi @Ekikereabasi-Nk Can you show me the error you are getting? I am also having little issues with the Check Project Structure / structure-check.

@Ekikereabasi-Nk
Copy link
Contributor Author

Ekikereabasi-Nk commented Oct 19, 2024

@KesharwaniArpita These are the error Run python check_project_structure.py
Errors found:

  • Unexpected file in Igbo/None/nouns: noun_query_2.sparql
  • Unexpected file in Igbo/None/nouns: noun_query_1.sparql
  • Unexpected file in Igbo/None/adverbs: adverb_query.sparql
  • Unexpected file in Igbo/None/prepositions: preposition_query.sparql
  • Unexpected file in Igbo/None/adjectives: adjective_query.sparql . The check_project_structure.py script expected files to be located in specific folders but found that some files are misplaced under a directory named None . But the None file is don't in my local repo or my origin.

@KesharwaniArpita
Copy link
Contributor

Hi again, So I was facing this error with my PR too. check_project_structure.py was showing that I had some unidentified files by the names emoji keywords which was also leading to more PR run fails. After a while I figured it out it was a naming convention error. The file was supposed to be named emoji_keywords instead of emoji keywords. I just fixed it and now its working fine.

To the best of my understanding check_project_structure.py is designed to validate the directory structure and the contents of the files in the repo, ensuring that all directories and files adhere to the expected organization.

I think this is the part that is causing the unexpected file errors where the error sub directory is coming out to be none:
image

You can also try renaming your files; like noun_query_2.sparql to query_nouns_2.sparql and the other files too so that it matches the given convention.

Hope it helps!! 😸

@Ekikereabasi-Nk
Copy link
Contributor Author

@KesharwaniArpita Thanks a lot I will try it out

@andrewtavis
Copy link
Member

Checking in here, are we ready for a review, or is there still some work to be done? Thanks for the collaboration, you two!

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 19, 2024
@andrewtavis andrewtavis self-requested a review October 19, 2024 13:50
@Ekikereabasi-Nk
Copy link
Contributor Author

Hi @andrewtavis I have done some minor update on the query, please take a look. Thank

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates here, @Ekikereabasi-Nk! I think that the amount of data isn't quite enough for us to have a good understanding of how the data will eventually be modeled, so let's keep the queries simple for now and expand them when more forms are available 😊

@andrewtavis andrewtavis merged commit aec9854 into scribe-org:main Oct 20, 2024
5 checks passed
@Ekikereabasi-Nk
Copy link
Contributor Author

Alright @andrewtavis, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants