-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and Refactor Latin Verb Query to Focus on Present Tense Forms #435
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Hi @andrewtavis would you take a look on the PR? Took me some time to figure out how to extract this much data and reduce the redundancy, I have written the query to extract the verbs associated with Present tense form. I wanted to ask if this query make sense? If yes, so I can follow up with the query for other forms of verbs too. So, I followed the set of grammatical features that uniquely defines a form of verb defined for the this lexeme and it turns out there are a lot of possible grammatical feature combinations. So, I was wondering if we should split this issue into smaller subsets and target each subset individually so that if someone else is also interested they can also help with it easily. |
Create query_verbs_7.sparql
The last commit is from @Otom-obhazi . Thanks for your help!!! |
I know this was a lot of work, @KesharwaniArpita, but I'm going to need to close this. I'll write in the verbs issue to give some more direction on how we should proceed here if there's still interest in working on this. |
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This WIP PR expands and refactors the existing SPARQL query to focus solely on Present Tense verb forms(till now) for Latin (Q397) verbs. The changes made include:
VALUES
block.OPTIONAL
blocks to align with this restriction, ensuring they cover Subjunctive, Imperative, and Indicative for different persons (First, Second, Third; Singular and Plural).Testing:
Future Work:
Past Tense: A similar refactor can be done to retrieve past tense verb forms(available on wikidata). These can be added using a
VALUES
block that filters for relevant grammatical features such as:Future Tense: The query can be extended to retrieve future tense forms by adding future-specific grammatical features:
Both Past and Future tense forms can follow the same pattern as this Present Tense query, with additional
VALUES
blocks or separate queries focused on those tenses.Impact:
The refactor improves the clarity and performance of the current query by focusing on a single tense while maintaining flexibility for future enhancements to cover other tenses.
Related issue