-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danish nouns #494
Danish nouns #494
Conversation
…able to resolve runtime issues. Previously combined three variables in one file leading to performance problems. Adding NonGenitive Form to the json file.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Do we need these queries split up as much as they are, @OmarAI2003? |
Well, previously, when I tried to group different combinations of two forms, I had a timeout error. Now I don’t think we need to make all those splits. I checked again and will make the necessary edits. |
I think it's honestly fine, @OmarAI2003 :) Just checking. |
@andrewtavis Now everything should be perfect, except there are duplicate entries per lexeme ID. That's because the actual forms on Wikidata are duplicated. For example, the same eight forms I got in this PR are in 16 forms for this example.The variable names in the files are different from Wikidata that's to pass the checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @OmarAI2003! Great to have Danish all finished up :)
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR refactors the SPARQL query by splitting it into separate eight files for each variable to resolve runtime issues. The original single-file implementation was leading to runtime problems. Adding the Non-Genitive Form to the JSON file To git red of erros by check_query_forms.
Related issue
Exuse me some for the MARKS and the spacing this was really erronous task.