Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish nouns #494

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Danish nouns #494

merged 7 commits into from
Oct 31, 2024

Conversation

OmarAI2003
Copy link
Contributor

Contributor checklist


Description

This PR refactors the SPARQL query by splitting it into separate eight files for each variable to resolve runtime issues. The original single-file implementation was leading to runtime problems. Adding the Non-Genitive Form to the JSON file To git red of erros by check_query_forms.

Related issue

Exuse me some for the MARKS and the spacing this was really erronous task.

…able to resolve runtime issues. Previously combined three variables in one file leading to performance problems. Adding NonGenitive Form to the json file.
Copy link

github-actions bot commented Oct 27, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 29, 2024 18:47
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 29, 2024
@andrewtavis
Copy link
Member

Do we need these queries split up as much as they are, @OmarAI2003?

@OmarAI2003
Copy link
Contributor Author

Do we need these queries split up as much as they are, @OmarAI2003?

Well, previously, when I tried to group different combinations of two forms, I had a timeout error. Now I don’t think we need to make all those splits. I checked again and will make the necessary edits.

@andrewtavis
Copy link
Member

I think it's honestly fine, @OmarAI2003 :) Just checking.

@OmarAI2003
Copy link
Contributor Author

@andrewtavis Now everything should be perfect, except there are duplicate entries per lexeme ID. That's because the actual forms on Wikidata are duplicated. For example, the same eight forms I got in this PR are in 16 forms for this example.The variable names in the files are different from Wikidata that's to pass the checks.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @OmarAI2003! Great to have Danish all finished up :)

@andrewtavis andrewtavis merged commit 0068350 into scribe-org:main Oct 31, 2024
7 checks passed
@OmarAI2003 OmarAI2003 deleted the Danish_nouns branch October 31, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The current Danish query for nouns results in a timeout error
2 participants