Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create query_preposition.sparql #510

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

Otom-obhazi
Copy link
Contributor

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Would you be able to check the workflow errors and make the needed changes, @Otom-obhazi? Thanks for sending along another contribution! :)

@andrewtavis andrewtavis self-requested a review November 19, 2024 10:38
@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Nov 19, 2024 via email

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix here was just moving the query into a directory, @Otom-obhazi :) It's good to get them all in directories such that we have a consistent structure as some of them might need to be moved into directories eventually if the results get to be too large.

Appreciate the continued support!

@andrewtavis andrewtavis merged commit 3cd3a85 into scribe-org:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants