Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: streamlined check_index_exists and removed redundancy #569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harikrishnatp
Copy link
Contributor

Contributor checklist


Description

As duplicates of existing files check existed in different files, it was not efficient and caused redundancy. Applied new logic to check_index_exists to adapt to different cases and removed the redundant code. I have written tests for different scenarios and manually tested it as well.

Related issue

#537

Copy link

Thank you for the pull request! ❤️

The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks so much for the PR, @harikrishnatp! Really appreciate you keeping this in mind :) Would you be able to do an initial review here, @axif0? :)

@axif0
Copy link
Collaborator

axif0 commented Feb 19, 2025

When trying the PR, I'm getting FileNotFoundError error, I tried

scribe-data g -a -dt verbs -od test

Actually in arabic verbs there is no query_verbs.sparql file exists.

image

@harikrishnatp, Did you also encounter the same error, or is it just me?

@harikrishnatp
Copy link
Contributor Author

Yes @axif0, I'm also getting the same error

@andrewtavis
Copy link
Member

Maybe there's an issue with the way that the default query is being set? Generally it checks to see if there's a .sparql file with *_1.sparql and then it doesn't check for the one that doesn't have a number at the end 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants