-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: streamlined check_index_exists and removed redundancy #569
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request! ❤️The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
Thanks so much for the PR, @harikrishnatp! Really appreciate you keeping this in mind :) Would you be able to do an initial review here, @axif0? :) |
When trying the PR, I'm getting
Actually in arabic verbs there is no @harikrishnatp, Did you also encounter the same error, or is it just me? |
Yes @axif0, I'm also getting the same error |
Maybe there's an issue with the way that the default query is being set? Generally it checks to see if there's a |
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
As duplicates of existing files check existed in different files, it was not efficient and caused redundancy. Applied new logic to check_index_exists to adapt to different cases and removed the redundant code. I have written tests for different scenarios and manually tested it as well.
Related issue
#537