Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update git-based project #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffgran
Copy link

@jeffgran jeffgran commented Oct 24, 2019

I moved the new command under a new project subcommand so that we could have more commands for working with projects grouped under that subcommand.

~~So instead of ~~

$ devbox new <NAME>

We have

$ devbox project new <NAME>

and

$ devbox project update <NAME>

Currently my version of the update command requires the git url to be passed again since we don't save it anywhere during the new command. I think it would be nice to make it optional, and reuse an existing url that we stash somewhere during new. I think we'd still have to always have the option, for existing projects that didn't have it saved, and I also think we'd want to have some way of updating the git url of an existing project in case you want to change it to a different branch or something. Maybe devbox project config --git <url> or something.

Adds a new renew command that re-generates (nay, copies/updates) a project config from a git repository so that existing projects can be updated. It requires passing the git url again since it is not stored anywhere.

(Fixes #3)

@w-sanches
Copy link

Other commands like devbox start and devbox build select projects through a -p flag, why not follow this here with a devbox update -p <project> command? They also read the default project from DEVBOX_PROJECT env var, which would be a nice to have for this new command.

In my mind everything would be thrown under the project umbrella since I can't recall a command that is not project related 🤔
Even something like logs would have an implicit devbox (project) logs in my mind 😆

@jeffgran
Copy link
Author

jeffgran commented Jan 9, 2020

@w-sanches that's a great point. One problem with using devbox update -p <project> is that the devbox update command already exists and is for updating a service within a project. I don't think I want to shoehorn both things to use the same update command even if it could be done with a flag or something. Maybe I'll just have to come up with a different name. Maybe devbox renew which echoes devbox new?

@jeffgran
Copy link
Author

jeffgran commented Jan 9, 2020

Updated.

Repository owner deleted a comment from tim-tepia Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a friendlier way to update a project configuration
2 participants