Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add EIP-7702 #1112
base: develop
Are you sure you want to change the base?
feat: add EIP-7702 #1112
Changes from all commits
8c459ec
85a8482
f3dfc7a
74b01b2
e8cff42
0d0511b
49ce6e2
9dddd1d
197739d
40ef7c7
1eac54c
cdc301f
70419dd
5257971
9a7229d
08cc2f9
f0e54b8
233a56f
7c2d9f4
9e70b14
2dc0756
15e71c9
3611717
51d6ec8
028347e
6d29693
2273e77
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these tests not work anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were legacy issues before this PR (I mistakenly marked them "regression problems" in the PR description, and changed that). Fixed one here: 2dc0756.
The fixed one is a state root mismatch, it's due to l2geth enabling 1559 transactions in Curie fork (instead of London fork), so after adding Curie fork block number 0 in "London" config it works again, otherwise the state transition would be different.
The trickier one is the "missing blockhash" case, I haven't found a clue yet. The test case is expected to return this error:
go-ethereum/cmd/evm/internal/t8ntool/transition.go
Line 48 in 2dc0756
But during the test, it applies the transaction but does not call this function:
go-ethereum/cmd/evm/internal/t8ntool/execution.go
Lines 104 to 117 in 2dc0756
which is the only place to return a
hashError
, to triggerErrorMissingBlockhash
here:go-ethereum/cmd/evm/internal/t8ntool/execution.go
Lines 190 to 192 in 2dc0756