New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented correct attribute handling #5

Merged

stefanScrumble merged 1 commit into master from @fix/correct-attribute-handling

May 2, 2024

Member

Luukdewaaier commented May 2, 2024

Summary

Added correct handling for the Attribute class:

If Attribute::get defined + existing corresponding DB column : @Property
If Attribute::get defined + no corresponding DB column : @property-read
If Attribute::set defined + existing corresponding DB column : @Property
If Attribute::set defined + no corresponding DB column : @property-write
If Attribute::get defined : @Property

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

Existing tests have been adapted and/or new tests have been added
Add a CHANGELOG.md entry
Update the README.md
Code style has been fixed via composer fix-style


          Implemented correct attribute handling

c32fe58

Luukdewaaier requested a review from stefanScrumble

May 2, 2024 15:33

Luukdewaaier self-assigned this

stefanScrumble merged commit 879b8f9 into master

28 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet