Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persistent filters #3909

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leejayhsu
Copy link

@leejayhsu leejayhsu commented Aug 1, 2024

Description

Use localstorage to save filters and orderBy settings in discover tv/movie pages.

Screenshot (if UI-related)

output

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@leejayhsu leejayhsu marked this pull request as ready for review August 1, 2024 20:35
@sct
Copy link
Owner

sct commented Aug 20, 2024

One issue I can imagine with this is that the sliders on the home page all apply filters when clicked on. These would then persist and override any of the expected persistent filters. This might be super confusing.

On top of that I would probably like to improve how we show filters are active on the movies/tv list. It's a bit hard to actually realize you have filters active (especially if you didn't actively set them).

@BillTheGoat
Copy link

BillTheGoat commented Jan 6, 2025

I agree that this is absolutely critical. I was about to abandon Jellyseerr until I saw this PR. However @sct is right that it is not fully integrated. I added this pr and rebuilt. What happens is the slider links do nothing, you just return to your previously defined filters.

Perhaps the best desired functionality would be that the slider link overwrites only the persistent filter for the filter category it is in. For example, a genre link from the main discover page would overwrite the persistent genres, but not the persistent languages or other active filters.

This would not be hard to implement. Just read the query params from the url, and merge with the savedFilters.

Does that sound like the right approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember Filters on Movies & Series
3 participants