Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): prevent password manager interference & improve service links #3989

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(ui): prevent password manager interference & improve service links #3989

wants to merge 1 commit into from

Conversation

s0up4200
Copy link
Contributor

@s0up4200 s0up4200 commented Dec 6, 2024

Description

This PR prevents unwanted password manager autofill in configuration forms and improves service link behavior.

Key Changes

  • Added password manager prevention attributes:
    • 1Password (data-1pignore)
    • LastPass (data-lpignore)
    • Bitwarden (data-bwignore)
  • Centralized prevention attributes in SensitiveInput component
  • Preserved Local Login form password manager functionality
  • Modified service links to open in new tabs
  • Removed redundant autoComplete="one-time-code" attributes

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

  • None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct Awaiting requested review from sct sct is a code owner

@TheCatLady TheCatLady Awaiting requested review from TheCatLady TheCatLady is a code owner

@danshilm danshilm Awaiting requested review from danshilm danshilm is a code owner

@OwsleyJr OwsleyJr Awaiting requested review from OwsleyJr OwsleyJr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s0up4200