(fix): correct shape for empty element in concat with dask #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 86.25% 83.84% -2.42%
==========================================
Files 41 41
Lines 6285 6288 +3
==========================================
- Hits 5421 5272 -149
- Misses 864 1016 +152
|
src/anndata/_core/merge.py
Outdated
| return el[self.old_idx.get_indexer(self.new_idx)] | ||
| return el[self.get_new_idx_from_old_idx()] | ||
|
|
||
| def get_new_idx_from_old_idx(self): |
There was a problem hiding this comment.
hm, is that the correct name? wouldn’t the accurate name contain an into or do I understand this API wrong (pandas docs are down, so I can‘t check)
There was a problem hiding this comment.
I'm not sure about into but perhaps just indexer and make this a property
flying-sheep
approved these changes
Feb 13, 2025
|
Good call! |
for more information, see https://pre-commit.ci
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Feb 13, 2025
…oncat with dask
flying-sheep
pushed a commit
that referenced
this pull request
Feb 13, 2025
…ith dask (#1861) Co-authored-by: Ilan Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concatnot working with differently sized input objects #1842