Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s-eks): use latest haproxy ingress controller version #6539

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

vponomaryov
Copy link
Contributor

@vponomaryov vponomaryov commented Aug 24, 2023

With the scylla-operator-1.10 we started getting HA problems [1] with the haproxy service.
So, fix it by using the latest available ingress controller version for haproxy.

[1] scylladb/scylla-operator#1341

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

With the scylla-operator-1.10 we started getting HA problems [1]
with the 'haproxy' service.
So, fix it by using the latest available ingress controller version for
haproxy.

[1] scylladb/scylla-operator#1341
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Question: how we assure we use the same as on production?

@vponomaryov
Copy link
Contributor Author

vponomaryov commented Aug 24, 2023

LGTM Question: how we assure we use the same as on production?

We have used the same.
They use image: haproxytech/kubernetes-ingress@sha256:324efe481132105631e12e5ab144d38dd533425705daa76cbbc78cdb91d8a662
We use 1.9.0.
It is the same: https://hub.docker.com/layers/haproxytech/kubernetes-ingress/1.9.0/images/sha256-324efe481132105631e12e5ab144d38dd533425705daa76cbbc78cdb91d8a662?context=explore

But, the latest one is more stable. And I would say that they should switch to the latest too.
I think no one updated it there just because of the busyness with other stuff.

And, finally, the haproxy solution will be replaced soon with the self-baked solution with required whistles which are absent in haproxy. So, we are ok to just make it more stable for now without big time investment from our side.

@vponomaryov
Copy link
Contributor Author

One more run showed that the problem is still in place: https://jenkins.scylladb.com/job/scylla-operator/job/operator-1.10/job/upgrade/job/upgrade-platform-k8s-eks/4/consoleFull
So, for now, with this latest version we have 1 failed run and 1 passed.

@vponomaryov vponomaryov reopened this Aug 24, 2023
@vponomaryov
Copy link
Contributor Author

Third run with this PR passed: https://jenkins.scylladb.com/job/scylla-operator/job/operator-1.10/job/upgrade/job/upgrade-platform-k8s-eks/5/
So, I consider it a pretty good results that 2 out of 3 runs pass when with old version 2 out of 2 failed.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 88ce717 into scylladb:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants