Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(offline-artifact-tests): use the correct nodetool script #8803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(offline-artifact-tests): use the correct nodetool script #8803

wants to merge 2 commits into from

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Sep 22, 2024 •
edited
Loading

so far the code was using the /share/cassandra/bin/nodetool that is the old java based nodetool that depends on JMX

and now it would use the script from /bin/nodetool that should default to using scylla nodetool command

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch fruch mentioned this pull request Sep 22, 2024
Open
@fruch fruch added backport/none Backport is not required and removed backport/6.2 labels Oct 1, 2024
@fruch
Copy link
Contributor Author

fruch commented Oct 1, 2024

but fix from seastar go into scylla core

trying the tests again

@fruch
Copy link
Contributor Author

fruch commented Oct 6, 2024

but fix from seastar go into scylla core

trying the tests again

@denesb it didn't helped, we are still failing on the same error on the nonroot offline installers tests

@fruch
fix(offline-artifact-tests): use the correct nodetool script
8c8cb35 
so far the code was using the `/share/cassandra/bin/nodetool`
that is the old java based nodetool that depends on JMX

and now it would use the script from `/bin/nodetool` that
should default to using `scylla nodetool` command
@fruch
test(nodetool): add seastar tracing for debugging
584f3c8
@fruch fruch force-pushed the artifact_use_scylla_nodetool branch from e9c0acf to 584f3c8 Compare October 9, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fruch fruch

Labels
backport/none Backport is not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fruch