full_storage_utilization_test: Storage utilization at 90% cluster size #9018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate data until it reaches over 90% disk storage and perform db and cluster options. Signed-off-by: Lakshmipathi <[email protected]>
Lakshmipathi
requested review from
lukepio and
paszkow
and removed request for
lukepio
paszkow
reviewed
Oct 21, 2024
| self.run_stress(93) | ||
|
|
||
| self.log.info("Adding a new node") | ||
| self.add_new_node() |
There was a problem hiding this comment.
One major comment here. Adding a node, will always succeed because you no longer write data. Your implementation of run_stress_until_target to prepare a cluster is fine. Once this is achieved, you want to rather react based on the storage utilization.
I think, this part of adding a node shall be written differently. Namely, you want to monitor the disk usage while writing bunch of data and if a certain threshold is reached, you extend a cluster by adding a new node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate data until it reaches over 90% disk storage then perform db and topology change cluster options.
Description
This PR covers basic part of 90% storage utilization, populate data when the cluster reaches over 90% disk usage
performs scaleout operation.Goal of this task is to run the cluster at 90% disk utilization. This will help the users to utilize their instances fully. To help achieve this goal, we need to utilize features like concurrent topology changes, tablets and migrations.
Keeping this as draft version so that it acts as common base between dev and qa team so it helps to improve this PR further.
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)