Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability of multiple inputs or outputs to each operator. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability of multiple inputs or outputs to each operator. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jquery.flowchart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,16 +210,17 @@ $(function() {
if (!multipleLinksOnOutput || !multipleLinksOnInput) {
for (var linkId2 in this.data.links) {
var currentLink = this.data.links[linkId2];
var currentOperator = this.data.operators[currentLink.fromOperator];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: replace the name of the variable to fromOperator, and add "toOperator = this.data.operators[currentLink.toOperator];", because of my remark below...


var currentSubConnectors = this._getSubConnectors(currentLink);
var currentFromSubConnector = currentSubConnectors[0];
var currentToSubConnector = currentSubConnectors[1];

if (!multipleLinksOnOutput && currentLink.fromOperator == linkData.fromOperator && currentLink.fromConnector == linkData.fromConnector && currentFromSubConnector == fromSubConnector) {
if (!multipleLinksOnOutput && !currentOperator.properties.multipleLinksOnOutput && currentLink.fromOperator == linkData.fromOperator && currentLink.fromConnector == linkData.fromConnector && currentFromSubConnector == fromSubConnector) {
this.deleteLink(linkId2);
continue;
}
if (!multipleLinksOnInput && currentLink.toOperator == linkData.toOperator && currentLink.toConnector == linkData.toConnector && currentToSubConnector == toSubConnector) {
if (!multipleLinksOnInput && !currentOperator.properties.multipleLinksOnInput && currentLink.toOperator == linkData.toOperator && currentLink.toConnector == linkData.toConnector && currentToSubConnector == toSubConnector) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use toOperator here, because the link is connector to the input of currentLink.toOperator and not currentLink.formOperator...

this.deleteLink(linkId2);
continue;
}
Expand Down