Fix module notifications with maskbit value of zero

sdss · Sep 3, 2024 · 6b66ef1 · 6b66ef1
1 parent 29c8726
commit 6b66ef1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Changelog
 
+## Next version
+
+### 🔧 Fixed
+
+* Fixed a bug that would make a module notification fail in some cases if its maskbit value was zero.
+
+
 ## 0.8.2 - August 19, 2024
 
 ### ✨ Improved

diff --git a/python/lvmecp/dome.py b/python/lvmecp/dome.py
@@ -65,7 +65,7 @@ async def _update_internal(self, use_cache: bool = True):
             new_status |= self.flag.POSITION_UNKNOWN
 
         if new_status.value == 0:
-            new_status = self.flag.__unknown__
+            new_status = self.flag(self.flag.__unknown__)
 
         return new_status
 

diff --git a/python/lvmecp/safety.py b/python/lvmecp/safety.py
@@ -66,7 +66,7 @@ async def _update_internal(self, use_cache: bool = True):
             new_status |= self.flag.RAIN_SENSOR_ALARM
 
         if new_status.value == 0:
-            new_status = self.flag.__unknown__
+            new_status = self.flag(self.flag.__unknown__)
 
         return new_status