Skip to content

Commit

Permalink
Change async_readout default to False in observe_tile
Browse files Browse the repository at this point in the history
  • Loading branch information
albireox committed Nov 7, 2024
1 parent 0bc2298 commit 421daf8
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## Next version

### 🔥 Breaking change

* `GortObserver.observe_tile` now default to `async_readout=False`. This will block until the exposure is done, which is a more natural behaviour for an external user that is not trying to over-optimise things. The code that uses `observe_tile` in GORT (`Gort.observe()` and `ObserverOverwatcher.observe_loop_task()`) have been updated to explicitly use `async_readout=True`.


## 1.0.2 - November 6, 2024

### 🚀 New
Expand Down
3 changes: 2 additions & 1 deletion src/gort/gort.py
Original file line number Diff line number Diff line change
Expand Up @@ -710,9 +710,10 @@ async def observe(

for ipos, dpos in enumerate(tile.dither_positions):
is_last = ipos == len(tile.dither_positions) - 1
result, _ = await self.observe_tile(
result, _ = await self.observer.observe_tile(
tile=tile,
dither_position=dpos,
async_readout=True,
keep_guiding=not is_last,
skip_slew_when_acquired=True,
run_cleanup=False,
Expand Down
2 changes: 1 addition & 1 deletion src/gort/observer.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ async def observe_tile(
dither_position: int | None = None,
exposure_time: float = 900.0,
n_exposures: int = 1,
async_readout: bool = True,
async_readout: bool = False,
keep_guiding: bool = False,
skip_slew_when_acquired: bool = True,
guide_tolerance: float = 1.0,
Expand Down
1 change: 1 addition & 0 deletions src/gort/overwatcher/observer.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ async def observe_loop_task(self):
result, _ = await observer.observe_tile(
tile=tile,
dither_position=dpos,
async_readout=True,
keep_guiding=True,
skip_slew_when_acquired=True,
run_cleanup=False,
Expand Down

0 comments on commit 421daf8

Please sign in to comment.