Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix camkes-deps build #146

Closed
wants to merge 1 commit into from
Closed

Fix camkes-deps build #146

wants to merge 1 commit into from

Conversation

Ax9D
Copy link

@Ax9D Ax9D commented Jun 28, 2024 •
edited
Loading

orderedset fails to build for python >= 3.11 as discussed here: #124.

Conditionally including it as a dependency for versions <= 3.10, bypasses the issue temporarily.

@Ax9D
Fix camkes-deps: install orderedset dependency only for old python ve…
82ab96b 
…rsions

orderedset fails to build in python >= 3.11 as discussed here:
seL4#124

Conditionally including it as a dependency for versions <= 3.10,
bypasses the issue temporarily
@lsf37
Copy link
Member

lsf37 commented Jun 30, 2024 •
edited
Loading

Thanks, @Ax9D. Since we're planning to do a release next week I've gone ahead in #147 with fully removing the package instead and bumping the version number. We'll do a release on pypi simultaneously with the rest some time next week (potentially Mon if we manage it).

@lsf37 lsf37 self-assigned this Jun 30, 2024
@Ax9D
Copy link
Author

Ax9D commented Jul 1, 2024

Sure, sounds good! I'm closing this.

@Ax9D Ax9D closed this Jul 1, 2024
@lsf37
Copy link
Member

lsf37 commented Jul 1, 2024

👍 Thanks for taking the time to provide a fix!

@Ax9D
Copy link
Author

Ax9D commented Jul 3, 2024

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lsf37 lsf37

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ax9D @lsf37