Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMv6 is no longer supported by seL4 #39

Closed
wants to merge 2 commits into from

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Mar 9, 2022

With seL4/seL4#580 the ARMv6 support has been removed. Thus there's no reason to accept "arm11" here any longer.

@lsf37
Copy link
Member

lsf37 commented Mar 9, 2022

Looks like arm11 is being referenced in a test somewhere still. Since we don't have many tests for this tool, we should probably update that (now) failing test instead of removing it.

@axel-h
Copy link
Member Author

axel-h commented Mar 9, 2022

Seem it's some more work, lots of referenced actually...

@axel-h axel-h marked this pull request as draft March 9, 2022 06:35
@axel-h
Copy link
Member Author

axel-h commented Mar 10, 2022

I've done some dumb replacement now and the build should work again. The binary python-capdl-tool/tests/resources/arm-hello.bin still needs to be replaced with an aarch32 version

@axel-h
Copy link
Member Author

axel-h commented Mar 10, 2022

I wonder, should we add ARM_HYP also or do we leave this as a future task that is only done if somebody really needs this?

@axel-h axel-h force-pushed the patch-axel-3 branch 11 times, most recently from f3ffc75 to 3c92322 Compare March 10, 2022 14:06
@lsf37 lsf37 requested a review from corlewis March 10, 2022 21:32
@lsf37
Copy link
Member

lsf37 commented Mar 10, 2022

I wonder, should we add ARM_HYP also or do we leave this as a future task that is only done if somebody really needs this?

I'd leave ARM_HYP as future task, esp since we want to get away from treating hyp as a separate architecture (not sure it'll be possible, but it'd be nice). @corlewis do you have any thoughts on this?

The other thing we will need to look at/change is all upstream code in other repos that produces those capDL specs. They will likely still reference arm11. In fact, there might be a lot more out there that we know of. We might want to support arm11 as a (strange, admittedly) syntax alternative for aarch32.

@axel-h
Copy link
Member Author

axel-h commented Mar 10, 2022

Is this why the " / capDL-tool (ghc)" fails:

/bin/sh: 1: dot: not found

or am I missing something?

@lsf37
Copy link
Member

lsf37 commented Mar 10, 2022

Is this why the " / capDL-tool (ghc)" fails:

/bin/sh: 1: dot: not found

or am I missing something?

I think you're right, we might need to add graphviz to the install in the action. Strange that this hasn't triggered before.

@kent-mcleod
Copy link
Member

kent-mcleod commented Mar 10, 2022

With seL4/seL4#580 the ARMv6 support has been removed. Thus there's no reason to accept "arm11" here any longer.

"arm11" is the capdl spec name that is used for aarch32 configurations. The biggest reason to keep accepting "arm11" is that it's what's always been used and it isn't causing any issues. The spec definition currently accepts one name for each architecture it understands which is quite simple.

@axel-h
Copy link
Member Author

axel-h commented Mar 11, 2022

@kent-mcleod: Based on you comment, should I drop this PR and make a new one that just adds comment explaining what this still exists? That should be sufficient to demystify things for anybody stumbling over this.

@lsf37
Copy link
Member

lsf37 commented Mar 11, 2022

That would be the minimal solution. I'm Ok with that, and this is really not high priority, but it'd be nice fix this name at least eventually (it's kinda my fault, I introduced it in the very beginning of capDL when verification supported only Arm11 and nothing else).

I'd be perfectly fine with the tool understanding both and producing a deprecation warning for arm11 for a few releases before we remove it. Actually removing all references is a bit of an operation.

@axel-h
Copy link
Member Author

axel-h commented Mar 11, 2022

Ok, See #40

- remove trailing spaces
- add linebreaks at end of file

Signed-off-by: Axel Heider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants