Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick additional features #1

Merged
merged 2 commits into from
May 30, 2018
Merged

Cherry pick additional features #1

merged 2 commits into from
May 30, 2018

Conversation

seahen
Copy link
Owner

@seahen seahen commented May 30, 2018

Incorporated features from outstanding pull requests on original project, including some by @mdedetrich

Removed setting of ACL to "Public" as a default. This isn't desired behaviour for private repos
Add support for reading AWS credentials from ~/.aws/credentials
Add support for Amazon EC2 Container Service
Depend only on aws-java-sdk-s3 instead of entire SDK.
Fix travis to work in trusty.

mdedetrich and others added 2 commits May 30, 2018 13:51
Add support for reading AWS credentials from ~/.aws/credentials
Add support for Amazon EC2 Container Service.
Depend only on aws-java-sdk-s3 instead of entire SDK.
Fix travis to work in modern travis.
@seahen seahen merged commit ac81ff1 into master May 30, 2018
@seahen seahen deleted the add-features branch May 30, 2018 18:23
@seahen
Copy link
Owner Author

seahen commented May 30, 2018

This should resolve the issues corresponding to jcaddel/maven-s3-wagon#19 and jcaddel/maven-s3-wagon#32 and incorporates most of what jcaddel/maven-s3-wagon#18, jcaddel/maven-s3-wagon#22, and jcaddel/maven-s3-wagon#33 intended.

I'm not planning on porting over the rest of the jcaddel PRs, but the original authors are welcome to and I'll merge ones that work. Now that this project is in maven central I'm going to actually use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants