Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodal z variable for particles #18

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

jmsexton03
Copy link
Member

No description provided.

@asalmgren
Copy link
Member

z_phys_nd(i,j,k)=0.5*(z_w(i,j,k)+z_w(i+1,j,k));
This formula isn't right -- we want to average all four z_w values (i,j), (i+1,j), (i,j+1), (i+1,j+1) onto the node

@asalmgren
Copy link
Member

Also see this error:

https://github.com/seahorce-scidac/docs.git/': The requested URL returned error: 403

@hklion
Copy link
Contributor

hklion commented Aug 23, 2023

Also see this error:

https://github.com/seahorce-scidac/docs.git/': The requested URL returned error: 403

This is a test configuration thing. I just pushed something to development that should fix this -- we were unconditionally trying to deploy the docs to the website, even on pull requests.

@jmsexton03
Copy link
Member Author

z_phys_nd(i,j,k)=0.5*(z_w(i,j,k)+z_w(i+1,j,k)); This formula isn't right -- we want to average all four z_w values (i,j), (i+1,j), (i,j+1), (i+1,j+1) onto the node

An update which addresses this had been pushed

@asalmgren asalmgren merged commit 92f09c6 into seahorce-scidac:development Aug 24, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants