Add compaction.failed event #52
Conversation
| }) | ||
| const error = await failure | ||
| if (!error || !(error instanceof Error) || error.message !== 'synthetic error') throw error | ||
| d.persistence.afterSerialization = afterSerializationOriginal |
There was a problem hiding this comment.
To make sure that this cleanup is always performed, it would be better to have this line in a finallly block.
There was a problem hiding this comment.
Test are independant, there is a beforeEach that resets everything, the final line is actually useless, I suggest to remove it rather than put it in a finally block.
|
Actually, as it has now been decided (for a better browser support) to remove imports of native node modules, including An option could be to shim Therefore, the |
No description provided.