feat: 插件数据库提供基于Gorm的存储结构 #1195
Draft
feat: 插件数据库提供基于Gorm的存储结构 #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a1acb183d6c656aa0c63b244368f0dde01c5c13a)
- 修改 BuntDBPluginStorage 初始化逻辑，使用插件名称创建独立数据库文件 - 优化 ExtInfo.StorageSet 和 StorageGet 方法，修复潜在的空指针问题 -重构 buntdb 存储实现，移除未使用的编码器和解码器 - 优化 gorm 存储实现，改进记录未找到时的错误处理 - 添加日志记录，提高代码可读性和调试方便性
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| log.Infof("closing buntdb plugin storage") | ||
| b.KVMap.Range(func(key string, value *bunt.Store) bool { | ||
| v := value | ||
| value = nil |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
ineffectual assignment to value (ineffassign)
| default: | ||
| d.Logger.Info("插件数据库初始化：BuntDB") | ||
| // 不需要定义名称 | ||
| d.PluginStorage, err = plugin_store.NewBuntDBPluginStorage(d.GetExtDataDir("")) |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
ineffectual assignment to err (ineffassign)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
采用了扩展的gokv的接口，以及部分它的实现方式。
暂时作为草稿，发出来各位品鉴一下#闭目
BTW: 这个是基于另一个缓存修改进行开发的。所以目前只能是个草稿。