-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Extend blueprint to include RequestBody properties #38
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4606277
to
34a9a2f
Compare
type: parsedProperty.type, | ||
format: property.format, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to define these in the blueprint spec. I'm not sure if we need type and format. I guess the main use case for type would be "json type" and format is "semantic meaning". But if we know something is a date or a uuid, then we also know it is a string.
I think at the blueprint level, it's more important to build on the semantics. So we IMO we want
export type Property =
| StringProperty
| EnumProperty
| RecordProperty
| ListProperty
| ObjectProperty
| BooleanProperty
| DatetimeProperty
| IdProperty
but we can still include the low level type info. How about we remove type
and do
interface StringProperty extends BaseProperty {
format: 'string'
jsonType: 'string'
}
interface DatetimeProperty extends BaseProperty {
format: 'datetime'
jsonType: 'string'
}
// ...
Closes #25