Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly handle null param values in Python code samples #53

Merged
merged 16 commits into from
Aug 8, 2024
Merged

fix: Correctly handle null param values in Python code samples #53

merged 16 commits into from
Aug 8, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Aug 6, 2024 •
edited
Loading

  • Correctly handle null param values in python code samples
  • Update code sample defs and test snapshot
  • Add formatPythonArrayResponse to improve readability

@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner August 6, 2024 10:17
@vercel Vercel
Copy link

vercel bot commented Aug 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blueprint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 11:26am

@andrii-balitskyi andrii-balitskyi changed the title Correctly handle null param values in python code samples fix: Correctly handle null param values in python code samples Aug 6, 2024
@andrii-balitskyi andrii-balitskyi changed the title fix: Correctly handle null param values in python code samples fix: Correctly handle null param values in Python code samples Aug 6, 2024
razor-x
razor-x approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@razor-x razor-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but please resolve comments first.

test/fixtures/types/code-sample-definitions.ts Outdated Show resolved Hide resolved
test/snapshots/blueprint.test.ts.md Outdated Show resolved Hide resolved
@razor-x razor-x mentioned this pull request Aug 7, 2024
Merged
@andrii-balitskyi andrii-balitskyi merged commit 3d8f9fb into main Aug 8, 2024
19 checks passed
@andrii-balitskyi andrii-balitskyi deleted the python-null-res-params branch August 8, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razor-x razor-x razor-x approved these changes

Assignees

@andrii-balitskyi andrii-balitskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-balitskyi @razor-x @seambot