Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add description to README #8

Merged
merged 9 commits into from
Jun 27, 2024
Merged

docs: Add description to README #8

merged 9 commits into from
Jun 27, 2024

Conversation

razor-x
Copy link
Collaborator

@razor-x razor-x commented Jun 27, 2024

No description provided.

@razor-x razor-x linked an issue Jun 27, 2024 that may be closed by this pull request
@razor-x razor-x marked this pull request as ready for review June 27, 2024 00:41
@razor-x razor-x requested a review from a team as a code owner June 27, 2024 00:41
@razor-x razor-x requested a review from sybohy June 27, 2024 00:41
README.md Outdated Show resolved Hide resolved
- Endpoint: a path that accepts an HTTP request and returns a response.
- Route: the direct parent path of a collection of one or more endpoints.
- Subroute: A route that is nested under another route.
- Namespace: the direct parent path of a collection routes only: there are no endpoints under this path.
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Namespace: the direct parent path of a collection routes only: there are no endpoints under this path.
- Namespace: the direct parent path of a collection of routes only; there are no endpoints under this path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no endpoints under this path.

Does it mean that noise_sensors is also a namespace, besides acs? Although, /noise_sensors could potentially have /get and /list endpoints since we have those for /locks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/noise_sensors/list should exist if it doesn't, it is not intended to be a namespace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no endpoints under /nosie_sensors. What about /noise_sensors/get, should we add it as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, only /nosie_sensors/list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +25 to +26
The scope of the [OpenAPI Specification](https://swagger.io/specification/) covers arbitrarily complicated APIs,
while the Seam API follows very predictable and simplified API design patterns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the line break intentional here?

Suggested change
The scope of the [OpenAPI Specification](https://swagger.io/specification/) covers arbitrarily complicated APIs,
while the Seam API follows very predictable and simplified API design patterns.
The scope of the [OpenAPI Specification](https://swagger.io/specification/) covers arbitrarily complicated APIs, while the Seam API follows very predictable and simplified API design patterns.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I break long lines in markdown intentionally. It doesn't change the format and it makes diffs / comments easier to target.

Note that linebreaks in github comments / issues do change the format (no idea why their parser is different 🤷🏻 ).

Comment on lines +31 to +32
- Extending the OpenAPI Specification with non-standard properties to support Seam's SDK and documentation requirements
is not directly compatible with existing tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with the line break

Suggested change
- Extending the OpenAPI Specification with non-standard properties to support Seam's SDK and documentation requirements
is not directly compatible with existing tools.
- Extending the OpenAPI Specification with non-standard properties to support Seam's SDK and documentation requirements is not directly compatible with existing tools.

README.md Outdated Show resolved Hide resolved
Comment on lines +41 to +42
- The blueprint is not limited by the OpenAPI Specification or constrained by the wide scope of supporting any API.
It is optimized for Seam's requirements and can evolve faster to meet Seam's specific concerns and integrate directly with other Seam integrated tooling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Suggested change
- The blueprint is not limited by the OpenAPI Specification or constrained by the wide scope of supporting any API.
It is optimized for Seam's requirements and can evolve faster to meet Seam's specific concerns and integrate directly with other Seam integrated tooling.
- The blueprint is not limited by the OpenAPI Specification or constrained by the wide scope of supporting any API. It is optimized for Seam's requirements and can evolve faster to meet Seam's specific concerns and integrate directly with other Seam integrated tooling.

Co-authored-by: Andrii Balitskyi <[email protected]>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Andrii Balitskyi <[email protected]>
Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blueprint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 6:23pm

@razor-x razor-x merged commit 9f12eef into main Jun 27, 2024
16 checks passed
@razor-x razor-x deleted the readme branch June 27, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add motivation and description
4 participants