Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code sample's request.parameters optional and default to {} #91

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Sep 24, 2024

Making request.parameters optional because we have instances of code samples where no params are passed. Usually, this occurs in requests to a /list endpoint.

@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner September 24, 2024 11:56
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blueprint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 6:32pm

src/lib/code-sample/javascript.ts Outdated Show resolved Hide resolved
@andrii-balitskyi andrii-balitskyi changed the title Make code sample's request.parameters nullable Make code sample's request.parameters optional and default to {} Sep 24, 2024
@andrii-balitskyi andrii-balitskyi merged commit 14552e9 into main Sep 24, 2024
19 checks passed
@andrii-balitskyi andrii-balitskyi deleted the nullable-code-sample-req-params branch September 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants