Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift properties up one level so they show in side nav #407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

razor-x
Copy link
Contributor

@razor-x razor-x commented Nov 1, 2024

image

@razor-x razor-x marked this pull request as ready for review November 1, 2024 20:27
@razor-x razor-x requested review from a team as code owners November 1, 2024 20:27
@razor-x razor-x changed the title Lift properties up one level Lift properties up one level so they show in side hav Nov 1, 2024
@razor-x razor-x changed the title Lift properties up one level so they show in side hav Lift properties up one level so they show in side nav Nov 1, 2024
@razor-x razor-x self-assigned this Nov 1, 2024
@DebbieAtSeam
Copy link
Contributor

I dunno, @razor-x... I don't love having the "Properties" title be the same heading level as the individual prop names. Also, for something like device, that would be an extremely long right-hand page menu.

@razor-x
Copy link
Contributor Author

razor-x commented Nov 1, 2024

What if we introduced some kind of groupings and/or ordering? Having just "Properties" on the nav does not seem useful

I like having a way at a glance on the side to scan and see all the property names and jump to the one I'm looking for.

@DebbieAtSeam
Copy link
Contributor

Also, has the title "Properties" been removed?

@razor-x
Copy link
Contributor Author

razor-x commented Nov 1, 2024

Yes I removed the Properties title. There isn't anything else to document for the resource here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants