Update WR using the master #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.13.9.1 Frontend2 v1.0.123 changes
Add a $ORIGIN-based rpath to the plugin so that the ld.so dynamic linker can locate plugin libraries also on flatpak, where the LD_LIBRARY_PATH mechanism which is used on native Linux cannot be used (the flatpak sandbox reserves this for internal use, since it might introduce dependencies outside the sandbox). Currently, we have no dynamic libraries used. However, using an rpath is a good habit which doesn't change anything if not required, while solving an otherwise tricky problem.
The tinyxml dependency lives in libs/tinyxml, and this file is just cruft which should be removed.
|
Should I close this since I merged the other patch? |
|
As I said above. |
|
Sean, This needs to be merged to be current. Also I have removed the frontend2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Master branc is missing July 02 to Sept 3 commits
This PR fixes that and brings your WR current