-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Format and apply rules #544
Conversation
clone._clause = _clause; | ||
clone._table = _table; | ||
|
||
clone._select = _select == null ? null : new List<string>(_select); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks suspicious, revert
@@ -1966,19 +1966,19 @@ await using (var session = _store.CreateSession()) | |||
await using (var session = _store.CreateSession()) | |||
{ | |||
Assert.Equal(2, await session.Query().For<Person>() | |||
.With<PersonByName>(x => x.SomeName.StartsWith("S")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not supported, only StartsWith(string) is bound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be added, but will require a custom test too, see static DefaultQuery()
Probably due to the changes methods (string to char) that I mentioned. It can't find the method (the one accepting a char) and tried to get the generic form but fails In You still need to use the "string" based one |
…yessql into ma/cleanup-formats
This PR apply some cleanup.
Also adds char support for StartsWith, EndsWith, and Contains